Gilad Chaplik has posted comments on this change.
Change subject: webadmin: action to stop brick removal operation
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
minor comments, fix on rebase.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 748: ConfirmationModel model = new ConfirmationModel();
Line 749: setConfirmWindow(model);
Line 750:
model.setTitle(ConstantsManager.getInstance().getConstants().stopRemoveBricksTitle());
Line 751:
model.setMessage(ConstantsManager.getInstance().getConstants().stopRemoveBricksMessage());
Line 752: model.setHashName("volume_remove_bricks_stop"); //$NON-NLS-1$
underscores...
Line 753:
Line 754: GlusterVolumeEntity volumeEntity = (GlusterVolumeEntity)
getEntity();
Line 755: ArrayList<String> list = new ArrayList<String>();
Line 756: for (GlusterBrickEntity brick : volumeEntity.getBricks()) {
Line 779: ConfirmationModel model = (ConfirmationModel)
getConfirmWindow();
Line 780:
Line 781: if (model.getProgress() != null) {
Line 782: return;
Line 783: }
I'm curious, why checking progress here?
Line 784:
Line 785: if (getSelectedItems() == null ||
getSelectedItems().isEmpty()) {
Line 786: return;
Line 787: }
--
To view, visit http://gerrit.ovirt.org/19387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d1653e168aa00b6b4c17d4608f5d96558aa462
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
