Omer Frenkel has posted comments on this change.
Change subject: core: LocalAdminPassword exception after engine restart
......................................................................
Patch Set 6:
(2 comments)
looks ok minor comments inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
Line 43: continue;
Line 44: }
Line 45:
Line 46: if
(generalOnlyPasswdConfigurationValues.contains(configValue)) {
Line 47: populateValueForConfigValue(configValue, "general",
configValuesMap);
please use ConfigCommon.defaultConfigurationVersion
Line 48: continue;
Line 49: }
Line 50:
Line 51: // Adding a configuration value for each version
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
Line 218: @Override
Line 219: public <T> T getValue(ConfigValues name, String version) {
Line 220: T returnValue;
Line 221: Map<String, Object> values = null;
Line 222: if ((values = _vdcOptionCache.get(name.toString())) != null
&& (values.containsKey(version))) {
this change can be removed completely
Line 223: returnValue = (T) values.get(version);
Line 224: } else {
Line 225: VdcOption option = new VdcOption();
Line 226: option.setoption_name(name.toString());
--
To view, visit http://gerrit.ovirt.org/18065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
