Daniel Erez has posted comments on this change.
Change subject: webadmin: Cannot add hypervisor host when use chinese support
......................................................................
Patch Set 4:
(2 comments)
We don't maintain a single file for all non-localized strings. But it could
indeed be a good idea to extract 'root' to a constant in the constants section
of HostModel (along with PmPort/etc). Either than that, looks good - just a
couple of minor formatting issues.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 853: setPasswordSection(new EntityModel());
Line 854: setAuthSshPort(new EntityModel());
Line 855: getAuthSshPort().setEntity(constants.defaultHostSSHPort());
Line 856: setUserName(new EntityModel());
Line 857: getUserName().setEntity("root"); //$NON-NLS-1$
fix formatting (some redundant spaces...)
Line 858: // TODO: remove setIsChangable when configured ssh username
is enabled
Line 859: getUserName().setIsChangable(false);
Line 860: setFetchSshFingerprint(new EntityModel());
Line 861: getFetchSshFingerprint().setEntity(constants.empty());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
Line 116:
Line 117: setOverrideIpTables(new EntityModel());
Line 118: getOverrideIpTables().setEntity(false);
Line 119: setUserName(new EntityModel());
Line 120: getUserName().setEntity("root"); //$NON-NLS-1$
fix formatting (some redundant spaces...)
Line 121: // TODO: remove setIsChangable when configured ssh username
is enabled
Line 122: getUserName().setIsChangable(false);
Line 123: setPublicKey(new EntityModel());
Line 124: getPublicKey().setEntity(constants.empty());
--
To view, visit http://gerrit.ovirt.org/19551
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
