Lior Vernia has posted comments on this change. Change subject: core, engine: sPAPR VLAN support ......................................................................
Patch Set 1: (1 comment) Hi Vitor, just to make sure I understand; so this new value will only be shown in the VM network interfaces dialog if the VM is ppc64, which will be determined via OsRepositoryQuery? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmInterfaceType.java Line 13: rtl8139_pv(0, "Dual mode rtl8139, VirtIO", "rtl8139_pv", 1000), Line 14: rtl8139(1, "rtl8139", "rtl8139", 100), Line 15: e1000(2, "e1000", "e1000", 1000), Line 16: pv(3, "VirtIO", "pv", 1000), Line 17: spapr_vlan(4, "sPAPR VLAN", "spapr-vlan", 1000); I'm actually not a stickler for naming conventions, but I'd ask you to change this to spaprVlan to conform to (most of the) rest of the project. Line 18: Line 19: private int value; Line 20: private String description; Line 21: private String internalName; -- To view, visit http://gerrit.ovirt.org/19878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12b9d760631200a9ae6508ecceb150854b2e9e6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
