Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: weird message on cleanup if no db
......................................................................


Patch Set 2:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-common/db/pgpass.py
Line 61:                     'is' if self.environment[
Line 62:                         osetupcons.DBEnv.PASSWORD
Line 63:                     ] is None
Line 64:                     else 'is not'
Line 65:                 )
well, if you try to hide the password... and I guess now this what you 
wanted... :)

 self.logger.debug('Password==None %s', self.env[...PASSWORD] is None)
Line 66:             )
Line 67:         )
Line 68:         if self.environment[osetupcons.DBEnv.PASSWORD] is not None:
Line 69:             with open(pgpass, 'w') as f:


-- 
To view, visit http://gerrit.ovirt.org/19886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba0ba1563acbf8c0ef900b304aa577a3dd1f615
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to