Allon Mureinik has uploaded a new change for review. Change subject: core: Fall-through in PolicyUnitImpl ......................................................................
core: Fall-through in PolicyUnitImpl Fixed the faulty (unintended) fall-through in PolicyUnitImpl.getPolicyUnitImpl(PolicyUnit). Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/19894/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java index 03a97d1..76df24b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java @@ -50,6 +50,7 @@ else if (policyUnit.getPolicyUnitType() == PolicyUnitType.LoadBalancing) { return new NoneBalancePolicyUnit(policyUnit); } + break; case "OptimalForPowerSaving": if (policyUnit.getPolicyUnitType() == PolicyUnitType.Weight) { return new PowerSavingWeightPolicyUnit(policyUnit); @@ -57,6 +58,7 @@ else if (policyUnit.getPolicyUnitType() == PolicyUnitType.LoadBalancing) { return new PowerSavingBalancePolicyUnit(policyUnit); } + break; case "OptimalForEvenDistribution": if (policyUnit.getPolicyUnitType() == PolicyUnitType.Weight) { return new EvenDistributionWeightPolicyUnit(policyUnit); @@ -64,9 +66,11 @@ else if (policyUnit.getPolicyUnitType() == PolicyUnitType.LoadBalancing) { return new EvenDistributionBalancePolicyUnit(policyUnit); } + break; default: - throw new NotImplementedException("policyUnit: " + policyUnit.getName()); + break; } + throw new NotImplementedException("policyUnit: " + policyUnit.getName()); } protected static final Log log = LogFactory.getLog(PolicyUnitImpl.class); -- To view, visit http://gerrit.ovirt.org/19894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
