Allon Mureinik has posted comments on this change.
Change subject: core: clearing snapshot_id on disk detach
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
Line 80: getVmDeviceDao().remove(vmDevice.getId());
Line 81:
Line 82: if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
Line 83: // clears snapshot ID
Line 84: getImageDao().updateImageVmSnapshotId(((DiskImage)
disk).getImageId(), Guid.Empty);
please use null instead of Guid.Empty, as would happen if using AddDiskCommand
with vmId=null.
Line 85: }
Line 86:
Line 87: // update cached image
Line 88: VmHandler.updateDisksFromDb(getVm());
--
To view, visit http://gerrit.ovirt.org/19895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
