Roy Golan has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
Line 160:
addCanDoActionMessage(VdcBllMessages.VDS_GROUP_CANNOT_DO_ACTION_NAME_IN_USE);
Line 161: result = false;
Line 162: }
Line 163: }
Line 164:
it is stated in the wiki:
"Do not allow cluster architecture be changed (processor name of different
architecture) while there are VMs and hosts attached"
and its a good point. the check below is missing that. did something change?
Line 165: // Check that the architecture type is equal
Line 166: if (result && getVdsGroup().getArchitecture() != null
Line 167: && StringUtils.isNotBlank(getVdsGroup().getcpu_name())
Line 168: &&
!checkIfArchitectureAndCpuNameMatch(getVdsGroup())) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 84:
newVmStatic.setCreationDate(oldVm.getStaticData().getCreationDate());
Line 85: if
(newVmStatic.getCreationDate().equals(DateTime.getMinValue())) {
Line 86: newVmStatic.setCreationDate(new Date());
Line 87: }
Line 88:
pls discard this change
Line 89: UpdateVmNetworks();
Line 90: getVmStaticDAO().update(newVmStatic);
Line 91: updateVmPayload();
Line 92: VmDeviceUtils.updateVmDevices(getParameters(), oldVm);
--
To view, visit http://gerrit.ovirt.org/18938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
