Juan Hernandez has posted comments on this change. Change subject: restapi: Use DbGroup instead of LdapGroup ......................................................................
Patch Set 2: (1 comment) I am not sure I understand your concern Yair, consistency is one of the things I am trying to enhance with this change. At the moment when the RESTAPI or the GUI work with groups they only use LdapUser, but the entity they manage should be DbUser, to be consistent with what happens with users. The use of LdapGroup should be limited, in my opinion, to where it is actually needed, and it is only needed when explicitly listing LDAP groups in the RESTAPI (api/domains/*/groups) and when adding groups and permissions. It doesn't make sense, for example, to use the LdapGroup entity when listing groups that have already been added to the database, as we currently do in api/groups, for example. What I try to do here is to make sure that api/groups uses only the DbGroup entity (and LdapGroup only when adding a group) and api/domains/*/groups uses only the LdapGroup entity. Can you further explain what you mean by "work with an uniform set of entities when coding queries"? .................................................... Commit Message Line 7: restapi: Use DbGroup instead of LdapGroup Line 8: Line 9: Currently the RESTAPI uses the LdapGroup entity in some places where Line 10: using DbGroup would make more sense, as it is actually dealing with Line 11: groiups stored in the database. This patch changes the RESTAPI to use Done Line 12: DbGroup instead. Line 13: Line 14: Change-Id: I6eed6456f92030dedec057950c5d331348da63da -- To view, visit http://gerrit.ovirt.org/19477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed6456f92030dedec057950c5d331348da63da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
