Gilad Chaplik has posted comments on this change.
Change subject: External Scheduler: Add memory example
......................................................................
Patch Set 2:
(2 comments)
....................................................
File plugins/examples/host_memory_balance.py
Line 3: import sys
Line 4:
Line 5:
Line 6: class host_memory_balance():
Line 7: '''moves a vm from a host with to many'''
/s/to/too
anyway consider rephrasing this sentence.
Line 8:
Line 9: #What are the values this module will accept, used to present
Line 10: #the user with options
Line 11: properties_validation = 'minimum_host_memory=[0-9]*'
Line 101: return
Line 102:
Line 103: #get our parameters from the map with default of 500MB
Line 104: minimum_host_memory = long(args_map.get('minimum_host_memory',
Line 105: 1024*1024*500))
where is the default?
Line 106:
Line 107: #get all the hosts with the given ids
Line 108: engine_hosts = self._get_hosts(hosts_ids, conn)
Line 109:
--
To view, visit http://gerrit.ovirt.org/19934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4a41064631912f5624723327a2ff5ebf158d5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
