Michael Kublin has posted comments on this change.
Change subject: Refactor UpdateStoragePoolCommand
......................................................................
Patch Set 6: (5 inline comments)
obne line
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 65:
use runVdsCommand() method from CommandBase, no need for VDSBrokerFrontend
resourceManager = Backend.getInstance.getResourceManager();
Line 99: try {
remove try , finally. No need
Line 126: }
write at single line return super.canDoAction() && checkStoragePool() &&
validateStoragePollName() && ....
Line 176:
make protected method getStorageDomainsStaticDAO() nad use it instedof
DbFacade.getInstance().getStorageDomainStaticDAO()
Line 196: _oldStoragePool = getStoragePoolDAO().get(sp.getId());
Move line _oldStoragePool = getStoragePoolDAO().get(sp.getId()); to constructor
or start of canDoaction
--
To view, visit http://gerrit.ovirt.org/2275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0978ffd7f22c19c58c8a2c6f1f9feafabb3cdf5b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
