Ramesh N has posted comments on this change.
Change subject: engine: Fix for return value issue in
StopRebalanceGlusterVolumeCommand
......................................................................
Patch Set 1:
(2 comments)
....................................................
Commit Message
Line 6:
Line 7: engine: Fix for return value issue in StopRebalanceGlusterVolumeCommand
Line 8:
Line 9: Discarding the status values returned from StopRebalance command as
it
Line 10: has issue during deserialization.
Done
Line 11:
Line 12: Change-Id: I90ec8b8495ede37a1dc6b8929cf80b445598a234
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 54: VDSReturnValue vdsReturnaValue =
Line 55:
runVdsCommand(VDSCommandType.StopRebalanceGlusterVolume,
Line 56: new
GlusterVolumeVDSParameters(upServer.getId(),
Line 57: getGlusterVolumeName()));
Line 58: setSucceeded(vdsReturnaValue.getSucceeded());
setSucceed() should be last statement as DB transactions may fail in
endStepJob() or releaseVolumeLock().
Line 59: if (!getSucceeded()) {
Line 60:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REBALANCE_STOP_FAILED,
vdsReturnaValue.getVdsError()
Line 61: .getMessage());
Line 62: return;
--
To view, visit http://gerrit.ovirt.org/19921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ec8b8495ede37a1dc6b8929cf80b445598a234
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
