Daniel Erez has posted comments on this change. Change subject: webadmin: changing tab order in HostPopupView ......................................................................
Patch Set 3: (2 comments) IIUC, this solution ensures that the OK/Cancel buttons are the last in tab index. If so, we should generalize/extract it to the infrastructure (probably into AbstractModelBoundPopupView). @Vojtech - what do you think? .................................................... Commit Message Line 5: CommitDate: 2013-10-02 18:23:13 -0400 Line 6: Line 7: webadmin: changing tab order in HostPopupView Line 8: Line 9: Instead of jumping to fingerprint field, just directly to OK button. Isn't the original solution solved the issue? Or, is it only for generalization purposes? Line 10: Line 11: Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011445 Line 13: Signed-off-by: Yaniv Bronhaim <[email protected]> .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java Line 765: }); Line 766: } Line 767: } Line 768: Line 769: private void setButtonsTabIndex(final int tabIndex) { IIUC, this solution ensures that the OK/Cancel buttons are the last in tab index. If so, we should generalize/extract it to the infrastructure (probably into AbstractModelBoundPopupView). @Vojtech - what do you think? Line 770: int nextTabIndex = tabIndex; Line 771: nextTabIndex = setButtonsTabIndex("OK", nextTabIndex); //$NON-NLS-1$ //$NON-NLS-2$ Line 772: setButtonsTabIndex("Cancel", nextTabIndex); //$NON-NLS-1$ //$NON-NLS-2$ Line 773: } -- To view, visit http://gerrit.ovirt.org/19692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
