Alon Bar-Lev has posted comments on this change. Change subject: engine: no documentation message ......................................................................
Patch Set 7: (3 comments) .................................................... File backend/manager/modules/root/src/main/webapp/404.jsp why not put this at WEB-INF like the other one? Line 1: <%@ page pageEncoding="UTF-8" session="false" %> Line 2: <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> Line 3: <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt"; %> Line 4: <%@ taglib prefix="obrand" tagdir="/WEB-INF/tags/obrand" %> .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp if the other one is within help, why not put prefix for this one as well? or maybe remove the /help prefix from the other one? Line 1: <%@ page pageEncoding="UTF-8" session="false" %> Line 2: <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> Line 3: <%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt"; %> Line 4: <%@ taglib prefix="obrand" tagdir="/WEB-INF/tags/obrand" %> .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java Line 219: * @return A {@code String} representation of the style sheet name. Line 220: */ Line 221: public String getThemeStyleSheet(ApplicationType type) { Line 222: if (type == null) { Line 223: type = DEFAULT_APPLICATION_TYPE; I still think this should be context parameter. Line 224: } Line 225: return brandingProperties.getProperty(type.getCssKey()); Line 226: } Line 227: -- To view, visit http://gerrit.ovirt.org/19848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
