Sandro Bonazzola has posted comments on this change. Change subject: Use the max=-1 option return unlimited results when calling the oVirt API. ......................................................................
Patch Set 2: Verified+1 > I think this is a good first step but the optimal solution is to use > pagination. This solution will break down if (and it is possible) if the > Engine is incapable of returning all results. In those instances you need > pagination to page through the results. Pagination and filtering moved to the query. I agree. I've already opened an RFE for that. Seems to work fine with basic sanity test with 1 Hypervisor. Lee, can you verify it with more than 100 Hypervisors? Just to be sure it doesn't fail due to the engine being not able to answer. -- To view, visit http://gerrit.ovirt.org/19759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
