Yair Zaslavsky has posted comments on this change.
Change subject: Allow activate hosts that support the engine's version
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java
Line 47: VDSGroup cluster = getVdsGroup();
Line 48: boolean vdsmVersionSupportedByEngine = false;
Line 49:
Line 50: // check that vdc support vds OR vds support vdc
Line 51: Version partialVdcVersion =
Not entirely sure what you're trying to do here?
Line 52: new Version(new Version(Config.<String>
GetValue(ConfigValues.VdcVersion)).toString(2));
Line 53: RpmVersion vdsVersion = vds.getVersion();
Line 54: Version vdsmVersion = new
Version(vdsVersion.getMajor(),vdsVersion.getMinor());
Line 55: if (!StringUtils.isEmpty(vds.getSupportedEngines())) {
Line 52: new Version(new Version(Config.<String>
GetValue(ConfigValues.VdcVersion)).toString(2));
Line 53: RpmVersion vdsVersion = vds.getVersion();
Line 54: Version vdsmVersion = new
Version(vdsVersion.getMajor(),vdsVersion.getMinor());
Line 55: if (!StringUtils.isEmpty(vds.getSupportedEngines())) {
Line 56: vdsmVersionSupportedByEngine =
vds.getSupportedENGINESVersionsSet().contains(partialVdcVersion);
Not sure what you tried to achieve here, please add a comment ?
Line 57: }
Line 58:
Line 59: // move to non operational if vds-vdc version not supported OR
cluster
Line 60: // version is not supported
--
To view, visit http://gerrit.ovirt.org/19992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b10f9ede37de858df0aa88185c75f2d84fc141
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
