Lior Vernia has uploaded a new change for review. Change subject: webadmin: Fixed behavior of "Required All" column header ......................................................................
webadmin: Fixed behavior of "Required All" column header It previously behaved as if required was identical to assigned, thus not affecting whether the network was required in the cluster from which the dialog was opened. Now it behaves as expected. Change-Id: I05fd73f64f2bbc38ce1b7bc4cf494d0cf1442f00 Bug-Url: https://bugzilla.redhat.com/1014661 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/20008/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java index 02e9e15..c1e92a8 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java @@ -277,9 +277,7 @@ @Override protected void selectionChanged(Boolean value) { for (NetworkClusterModel networkClusterModel : getClustersTableItems()) { - if (networkClusterModel.getIsChangable()) { - networkClusterModel.setRequired(value); - } + networkClusterModel.setRequired(value); } refreshClustersTable(); } @@ -287,7 +285,7 @@ @Override public Boolean getValue() { for (NetworkClusterModel networkClusterModel : getClustersTableItems()) { - if (networkClusterModel.getIsChangable() && !networkClusterModel.isRequired()) { + if (!networkClusterModel.isRequired()) { return false; } } -- To view, visit http://gerrit.ovirt.org/20008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05fd73f64f2bbc38ce1b7bc4cf494d0cf1442f00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
