Moti Asayag has posted comments on this change.
Change subject: engine: Utility class for managing external networks
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java
Line 21: * the vNIC.
Line 22: *
Line 23: * @param nic
Line 24: * The vNIC to create a manager for.
Line 25: */
does this c'tor required ? it makes the usage of this class less intuitive.
Line 26: public ExternalNetworkManager(VmNic nic) {
Line 27: this.nic = nic;
Line 28: }
Line 29:
Line 58: /**
Line 59: * Deallocate the vNIC from the external network, if it's attached
to a network and the network is indeed an
Line 60: * external network (otherwise, nothing is done).
Line 61: */
Line 62: public void deallocateIfExternal() {
will this code reside in a protective block that assure it is being invoked
from the correct context ?
Line 63: if (getNetwork() != null && getNetwork().isExternal()) {
Line 64: NetworkProviderProxy providerProxy =
ProviderProxyFactory.getInstance().create(
Line 65:
DbFacade.getInstance().getProviderDao().get(getNetwork().getProvidedBy().getProviderId()));
Line 66: providerProxy.deallocate(nic);
--
To view, visit http://gerrit.ovirt.org/19965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c93d7a74c66bbcae54cd4667744b0a88882622c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
