Allon Mureinik has posted comments on this change. Change subject: core: mark GetVirtioScsiControllers as user query ......................................................................
Patch Set 1: Code-Review-1 No, this is not safe. Follow the call-stack 1. GetVirtioScsiControllersQuery calls VmDeviceUtils.getVirtioScsiControllers(getParameters().getId()) 2. VmDeviceUtils.getVirtioScsiControllers(Guid) calls VmDeviceDao.getVmDeviceByVmIdTypeAndDevice( vmId, VmDeviceGeneralType.CONTROLLER, VmDeviceType.VIRTIOSCSI.getName()) 3. VmDeviceDao.getVmDeviceByVmIdTypeAndDevice(Guid vmId, VmDeviceGeneralType type, String device) calls getVmDeviceByVmIdTypeAndDevice(vmId, type, device, null, false) In other words - the stored procedure supports filtering, but the API you're using *always* calls the non-filtered version. -- To view, visit http://gerrit.ovirt.org/20003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I268b39bc85525a270998c10b67c2463a45a08a26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
