Kanagaraj M has posted comments on this change.
Change subject: webadmin: Bricks sub-tab under Hosts
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBricksListModel.java
Line 46: {
Line 47: super.entityPropertyChanged(sender, e);
Line 48:
Line 49: if (e.PropertyName.equals("status")) //$NON-NLS-1$
Line 50: {
no need to worry about the status of the host here
Line 51: getSearchCommand().execute();
Line 52: }
Line 53: }
Line 54:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java
Line 175: public static final String hostGlusterSwiftSubTabPlace =
hostMainTabPlace + SUB_TAB_PREFIX
Line 176: + "gluster_swift"; //$NON-NLS-1$
Line 177:
Line 178: public static final String hostBricksSubTabPlace =
hostMainTabPlace + SUB_TAB_PREFIX
Line 179: + "host_bricks"; //$NON-NLS-1$
this can be "gluster_bricks"
Line 180:
Line 181: public static final String hostPermissionSubTabPlace =
hostMainTabPlace + SUB_TAB_PREFIX
Line 182: + "permissions"; //$NON-NLS-1$
Line 183:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostBrickPresenter.java
Line 35:
Line 36: @TabInfo(container = HostSubTabPanelPresenter.class)
Line 37: static TabData getTabData(ApplicationConstants
applicationConstants,
Line 38: SearchableDetailModelProvider<GlusterBrickEntity,
HostListModel, HostBricksListModel> modelProvider) {
Line 39: return new
ModelBoundTabData(applicationConstants.hostBricksSubTabLabel(), 4,
modelProvider);
position 4 is already used by another tab. You would need to a right-shift of
the presenters positioned on or after 4
Line 40: }
Line 41:
Line 42: @Inject
Line 43: public SubTabHostBrickPresenter(EventBus eventBus, ViewDef view,
ProxyDef proxy,
--
To view, visit http://gerrit.ovirt.org/19989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic67c2aba2a5cd90832e6aa8c63c016ccef96ee50
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
