Sahina Bose has posted comments on this change.
Change subject: engine: Populate task entity on brick
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 316: volume.setAccessProtocols(new
HashSet<AccessProtocol>(getAccessProtocolsOfVolume(volume.getId())));
Line 317: volume.setTransportTypes(new
HashSet<TransportType>(getTransportTypesOfVolume(volume.getId())));
Line 318: volume.setAsyncTask(getAsyncTaskOfVolume(volume.getId()));
Line 319: List<GlusterBrickEntity> bricks =
dbFacade.getGlusterBrickDao().getBricksOfVolume(volume.getId());
Line 320: if (volume.getAsyncTask()!=null &&
volume.getAsyncTask().getStepId() != null) {
You're right, changing
Line 321: for (GlusterBrickEntity brick: bricks)
Line 322: {
Line 323: if (brick.getAsyncTask() != null &&
brick.getAsyncTask().getTaskId().equals(volume.getAsyncTask().getTaskId())) {
Line 324: brick.setAsyncTask(volume.getAsyncTask());
Line 319: List<GlusterBrickEntity> bricks =
dbFacade.getGlusterBrickDao().getBricksOfVolume(volume.getId());
Line 320: if (volume.getAsyncTask()!=null &&
volume.getAsyncTask().getStepId() != null) {
Line 321: for (GlusterBrickEntity brick: bricks)
Line 322: {
Line 323: if (brick.getAsyncTask() != null &&
brick.getAsyncTask().getTaskId().equals(volume.getAsyncTask().getTaskId())) {
Done as part of earlier change
Line 324: brick.setAsyncTask(volume.getAsyncTask());
Line 325: }
Line 326: }
Line 327: }
--
To view, visit http://gerrit.ovirt.org/20017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f72371323ef7696313b5333707ef4f3f771e7e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
