Alon Bar-Lev has posted comments on this change.
Change subject: core: Remove Windows ProductKey* from db
......................................................................
Patch Set 7:
(4 comments)
Thanks! forgive me for abusing you with indentation...
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/productkey_upgrade.py
Line 66: content = []
Line 67: for key in self.DB_TO_OSINFO.keys():
Line 68: val = self.environment[
Line 69: osetupcons.DBEnv.STATEMENT
Line 70: ].getVdcOption(key)
please align this last line at place the statement begins (one indent left).
Line 71: if len(val) > 0:
Line 72: content.append('os.%s.productKey.value=%s' %
Line 73: (self.DB_TO_OSINFO[key], val))
Line 74:
Line 67: for key in self.DB_TO_OSINFO.keys():
Line 68: val = self.environment[
Line 69: osetupcons.DBEnv.STATEMENT
Line 70: ].getVdcOption(key)
Line 71: if len(val) > 0:
I am quite sure you can ask if val, but not that important.
Line 72: content.append('os.%s.productKey.value=%s' %
Line 73: (self.DB_TO_OSINFO[key], val))
Line 74:
Line 75: if len(content) > 0:
Line 69: osetupcons.DBEnv.STATEMENT
Line 70: ].getVdcOption(key)
Line 71: if len(val) > 0:
Line 72: content.append('os.%s.productKey.value=%s' %
Line 73: (self.DB_TO_OSINFO[key], val))
please do not draw code... always have single indent per block:
content.append(
'os.%s.productKey.value=%s' % (
self.DB_TO_OSINFO[key],
val,
)
)
Line 74:
Line 75: if len(content) > 0:
Line 76:
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 77: filetransaction.FileTransaction(
Line 71: if len(val) > 0:
Line 72: content.append('os.%s.productKey.value=%s' %
Line 73: (self.DB_TO_OSINFO[key], val))
Line 74:
Line 75: if len(content) > 0:
I am quite sure you can ask if content, but not that important.
Line 76:
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 77: filetransaction.FileTransaction(
Line 78:
name=osetupcons.FileLocations.EXTRACTED_PRODUCTKEYS,
Line 79: content=content,
--
To view, visit http://gerrit.ovirt.org/19743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
