Sahina Bose has posted comments on this change.
Change subject: gluster: Remove bricks from DB after commit completion
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
Line 79: endStepJobCommitted();
Line 80: releaseVolumeLock();
Line 81: getDbUtils().removeBricksFromVolumeInDb(volume,
Line 82: getParameters().getBricks(),
Line 83: getParameters().getReplicaCount());
release lock after bricks are removed
Line 84:
getReturnValue().setActionReturnValue(returnValue.getReturnValue());
Line 85: }
Line 86:
Line 87: protected void endStepJobCommitted() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 70: setSucceeded(returnValue.getSucceeded());
Line 71: if (getSucceeded()) {
Line 72:
GlusterDBUtils.getInstance().removeBricksFromVolumeInDb(getGlusterVolume(),
Line 73: getParameters().getBricks(),
Line 74: getParameters().getReplicaCount());
pass replicaCount variable here
Line 75: } else {
Line 76:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REMOVE_BRICKS_FAILED,
returnValue.getVdsError().getMessage());
Line 77: return;
Line 78: }
--
To view, visit http://gerrit.ovirt.org/20109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a21f013833833710abc219c1a066a2250bc5fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
