Sandro Bonazzola has posted comments on this change.
Change subject: agent: use vdsm domain monitor
......................................................................
Patch Set 1: -Code-Review
(1 comment)
....................................................
File ovirt_hosted_engine_ha/agent/hosted_engine.py
Line 433: .format(sd_uuid, host_id, str(e)))
Line 434: self._log.error(msg, exc_info=True)
Line 435: raise Exception(msg)
Line 436: else:
Line 437: self._log.info("Started VDSM domain monitor for %s",
sd_uuid)
here you should also wait for the monitor acquiring the lock
Line 438:
Line 439: def _collect_local_stats(self):
Line 440: """
Line 441: Refresh all required submonitors and update local state.
--
To view, visit http://gerrit.ovirt.org/20051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bab369784fecbf972622922a925fd0b45de123f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
