Roy Golan has posted comments on this change.
Change subject: core: adding HA score with proper scheduling policies
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterFilterPolicyUnit.java
Line 27: hostsToRunOn.add(host);
Line 28: log.debugFormat("Host {0} wasn't filtered out as
it has a score of {1}",
Line 29: host.getName(),
Line 30:
host.getDynamicData().getHighlyAvailableScore());
Line 31: } else {
the check from the if above is that score != 0 and not > 0
but the log says it wasn't positive.
if the score by contract (VDSM API) is never negative so this check above
should check >0
if not than the negative score has a meaning which isn't reflected here.
Line 32: log.debugFormat("Host {0} was filtered out as it
doesn't have a positive score", host.getName());
Line 33: }
Line 34: }
Line 35:
Line 33: }
Line 34: }
Line 35:
Line 36: if (hostsToRunOn.isEmpty()) {
Line 37:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_HA_VDS.toString());
pls use enum.name() instead of toString()
Line 38: }
Line 39:
Line 40: return hostsToRunOn;
Line 41: } else {
--
To view, visit http://gerrit.ovirt.org/20018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
