Allon Mureinik has posted comments on this change.
Change subject: engine: Remove calls to getImageDomainsList API
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommandTest.java
Line 28: public class MoveOrCopyTemplateCommandTest {
Line 29:
Line 30: private Guid[] diskIds = {Guid.newGuid(), Guid.newGuid(),
Guid.newGuid()};
Line 31: private Guid targetStorageDomainId = Guid.newGuid();
Line 32: private Guid storagePoolId = Guid.newGuid();
This blow should be in a @Before method, not the (implicit) constructor
Line 33:
Line 34: @Test
Line 35: public void checkIfDisksExistAllDisksOnSameSD() {
Line 36: // Prepare test case
--
To view, visit http://gerrit.ovirt.org/15951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33069871db34e8b129c4d80098523654cd2a0629
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
