Alissa Bonas has uploaded a new change for review.

Change subject: engine: change formatter "addNewLine" to "insert"
......................................................................

engine: change formatter "addNewLine" to "insert"

Change the code formatter configuration to have "addNewLine"
set to "insert" instead of "do not insert" to align it with the
checkstyle validations that fails if there's no new line in the end of
file.

Change-Id: I495e11e20c315e267e9f8141f7fecf45e39a3363
Signed-off-by: Alissa Bonas <[email protected]>
---
M config/engine-code-format.xml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/20150/1

diff --git a/config/engine-code-format.xml b/config/engine-code-format.xml
index 5b05a6f..34f79a4 100644
--- a/config/engine-code-format.xml
+++ b/config/engine-code-format.xml
@@ -178,7 +178,7 @@
 <setting id="org.eclipse.jdt.core.formatter.keep_imple_if_on_one_line" 
value="false"/>
 <setting 
id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_constructor_declaration_parameters"
 value="do not insert"/>
 <setting 
id="org.eclipse.jdt.core.formatter.insert_space_after_closing_angle_bracket_in_type_parameters"
 value="insert"/>
-<setting 
id="org.eclipse.jdt.core.formatter.insert_new_line_at_end_of_file_if_missing" 
value="do not insert"/>
+<setting 
id="org.eclipse.jdt.core.formatter.insert_new_line_at_end_of_file_if_missing" 
value="insert"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_for" 
value="insert"/>
 <setting 
id="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_labeled_statement"
 value="do not insert"/>
 <setting 
id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_parameterized_type_reference"
 value="do not insert"/>


-- 
To view, visit http://gerrit.ovirt.org/20150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I495e11e20c315e267e9f8141f7fecf45e39a3363
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to