Tomas Jelinek has posted comments on this change.
Change subject: UI: support multi monitor only for cluster 3.3 and up
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1727: handleQxlClusterLevel();
Line 1728: }
Line 1729:
Line 1730: private void handleQxlClusterLevel() {
Line 1731: // Enable Single PCI only on cluster 3.3 and high and on
Linux OS
It is not completely correct - from this logic the single PCI would be enabled
if the selectedCluster is null.
I would change the logic to something like this:
boolean isLinux = getIsLinuxOS();
boolean isQxl = getDisplayType() == DisplayType.qxl;
boolean clusterSupportsSinglePci = getSelectedCluster() != null &&
Version.v3_3.compareTo(getSelectedCluster().getco
mpatibility_version()) <= 0;
getBehavior().enableSinglePCI(isLinux && isQxl && clusterSupportsSinglePci);
Line 1732: if (!getIsLinuxOS()) {
Line 1733: getBehavior().enableSinglePCI(false);
Line 1734: } else if ( getDisplayType() == null || getDisplayType() !=
DisplayType.qxl) {
Line 1735: getBehavior().enableSinglePCI(false);
--
To view, visit http://gerrit.ovirt.org/19468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
