Martin Peřina has posted comments on this change.
Change subject: core: in PM only selecting apc or ipmilan...
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java
Line 5: import
org.ovirt.engine.core.common.queries.GetAgentFenceOptionsQueryParameters;
Line 6: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase;
Line 7: import org.ovirt.engine.core.utils.pm.VdsFenceOptions;
Line 8:
Line 9: public class GetAgentFenceOptionsQuery<P extends
VdcQueryParametersBase> extends FenceQueryBase<P> {
Wouldn't it be more correct to change declaration to:
... <P extends GetAgentFenceOptionsQueryParameters> ...
so the cast won't be needed in executeQueryCommand()
Line 10:
Line 11: public GetAgentFenceOptionsQuery(P parameters) {
Line 12: super(parameters);
Line 13: }
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java
Line 44: */
Line 45: public VdsFenceOptions(String version) {
Line 46: this.version = version;
Line 47: InitCache();
Line 48: Init();
Wouldn't it be better to use contructor chaining?
public VdsFenceOptions(String version) {
this(null, null, version);
}
Line 49: }
Line 50:
Line 51: /**
Line 52: * Initializes a new instance of the <see
cref="VdsFencingOptions"/> class.
--
To view, visit http://gerrit.ovirt.org/20090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
