Michael Pasternak has posted comments on this change. Change subject: cli: update on vm --os-boot does not work as expected(#1012985) ......................................................................
Patch Set 2: (1 comment) .................................................... File src/ovirtcli/command/command.py Line 143: if attrList != None and clearListData: Line 144: attrListLen = len(attrList) Line 145: for x in range(0, attrListLen): Line 146: attrList.pop() Line 147: clearListData = False why just not create new type instance and put there the content from candidate? (if it has any content) Line 148: if getattr(obj_params_set_cand, param_period) != None: Line 149: getattr(obj, props[i]).append(obj_params_set_cand) Line 150: obj_params_set_cand = params_set_cand.factory() Line 151: root_obj_params_set_cand = obj_params_set_cand -- To view, visit http://gerrit.ovirt.org/20098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc3aa9c42fed2f6fc423e106096f197ef4be3819 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
