Juan Hernandez has posted comments on this change.
Change subject: userportal,webadmin: frontend refactor phase 2
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
As long as you aren't introducing a new user-like entity I am OK, and you
aren't. Only two small comments inside.
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcUserCallback.java
Line 2:
Line 3: /**
Line 4: * The callback interface for user operations such as logging in and
out.
Line 5: */
Line 6: public interface VdcUserCallback<R> {
As the VdcUser entity doesn't exist now I would suggest to rename this class
accordingly, maybe just "UserCallback" or "AuthenticationCallback".
Line 7: /**
Line 8: * Success callback.
Line 9: * @param result The result of the operation.
Line 10: */
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java
Line 102: Window.Location.reload();
Line 103: }
Line 104:
Line 105: //Frontend.clearLoggedInUser();
Line 106: frontend.setLoggedInUser(null);
The "clearLoggedInUser" method used to clear both the user and the password.
Where is the password cleared now?
Line 107: getLoginModel().resetAfterLogout();
Line 108: AsyncDataProvider.clearCache();
Line 109: connectAutomaticallyManager.resetAlreadyOpened();
Line 110: ApplicationInit.super.onLogout();
--
To view, visit http://gerrit.ovirt.org/17356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id19491b8fd4f30ad3a88790eaad664d679b35e22
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
