Ori Liel has posted comments on this change.
Change subject: core: Add POWER 7 to the CPU list
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ServerCpuParser.java
Line 28: * Format is <level>:<name>:<flag>,<flag>,...:<verb>:<architecture>
Line 29: *
Line 30: * e.g. 3:Intel Xeon Core2:vmx,nx,model_Conroe:Conroe:x86_64
Line 31: */
Line 32: public static ServerCpu parseCpu(String str) {
This method parses the string from the engine and creates a ServerCpu object.
It is invoked when client GETs 'http://.../api/capabilities', and publishes the
CPUs known to the system.
In BackendCapabilitiesResource-->generateVersionCaps() (the only client of this
method) the ServerCpu objects are turned into their counterpart API entities
'CPU'. This is done by explicitly mapping each field. I would expect mapping of
the architecture field to appear there too, but it doesn't. Please add that.
Line 33: String[] parts = str.split("[:]", -1);
Line 34:
Line 35: if (parts.length != 5) {
Line 36: throw new IllegalArgumentException("Invalid CPU
description: '" + str + "'");
--
To view, visit http://gerrit.ovirt.org/17853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
