Yaniv Bronhaim has posted comments on this change. Change subject: host-deploy: configure ssh port per port used to actual communications ......................................................................
Patch Set 1: (2 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-10-14 23:39:03 +0300 Line 4: Commit: Alon Bar-Lev <[email protected]> Line 5: CommitDate: 2013-10-14 23:39:09 +0300 Line 6: Line 7: host-deploy: configure ssh port per port used to actual communications configure ssh port to the one configured during add\editHost operations Line 8: Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018948 Line 10: Change-Id: I1b581f81ad3f11b22eb20b72d34a41fae47f18bc .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java Line 211: IPTABLES_CUSTOM_RULES_PLACE_HOLDER, Line 212: serviceIPTablesConfig Line 213: ).replace( Line 214: IPTABLES_SSH_PORT_PLACE_HOLDER, Line 215: Integer.toString(_vds.getSshPort()) what if sshPort is modified during edit host ? do we rebuild the iptables? Line 216: ); Line 217: Line 218: return ipTablesConfig; Line 219: } -- To view, visit http://gerrit.ovirt.org/20174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b581f81ad3f11b22eb20b72d34a41fae47f18bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
