Moti Asayag has posted comments on this change.
Change subject: core: In commit http://gerrit.ovirt.org/#/c/15795/16 a bug was
introduced causing certain commands to miss a correlationId (see bug
description comment). correlationId must be written on thread local to get
logged.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 179: // this is used for async task completion to get the user who
initiated
Line 180: // the task after the user has logged out.
Line 181: if (parameters.getParametersCurrentUser() != null) {
Line 182: setCurrentUser(parameters.getParametersCurrentUser());
Line 183: }
since the logic of the 'if' statement shifted into
CommandBase.setCorrelationId, it can be deleted from the c'tor.
Line 184: // correlation ID thread local variable is set for non
multi-action
Line 185: if (!parameters.getMultipleAction()) {
Line 186:
ThreadLocalParamsContainer.setCorrelationId(parameters.getCorrelationId());
Line 187: }
--
To view, visit http://gerrit.ovirt.org/20160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie416d6f48f6209985f3cae36566a475e7fa90963
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
