Tomas Jelinek has posted comments on this change.
Change subject: engine,frontend: localize snapshot type on FE
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java
Line 64: descriptionStr = descriptionStr + " (" +
constants.readonlyLabel() + ")"; //$NON-NLS-1$ //$NON-NLS-2$
Line 65: description =
templates.snapshotDescription("font-style:italic", descriptionStr);
//$NON-NLS-1$
Line 66: }
Line 67: else if (snapshot.getType() == SnapshotType.ACTIVE ||
snapshot.getType() == SnapshotType.PREVIEW) {
Line 68: descriptionStr = snapshot.getType() ==
SnapshotType.ACTIVE ? constants.snapshotDescriptionActiveVm() :
constants.snapshotDescriptionActiveVmBeforePreview();
you are right, I have removed the backend part of the patch so the REST will
not change. So now only the FE adds the localization.
Line 69: description =
templates.snapshotDescription("color:gray", descriptionStr); //$NON-NLS-1$
Line 70: }
Line 71:
Line 72: return description;
--
To view, visit http://gerrit.ovirt.org/19542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26866fd4dd91d034e7ae5afee054080a4ab864a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
