Michael Pasternak has posted comments on this change.
Change subject: rest: VirtIO-SCSI enabled flag
......................................................................
Patch Set 12:
(3 comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmResourceHelper.java
Line 1: package org.ovirt.engine.api.restapi.resource;
Line 2:
Line 3: public class VmResourceHelper extends BackendResource {
afaiu VmHelper replaces this class, so it's no longer needed
Line 4:
Line 5: private static VmResourceHelper instance;
Line 6:
Line 7: private VmResourceHelper() {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
Line 7: import java.util.List;
Line 8:
Line 9: public class VmHelper extends ResourceHelper {
Line 10:
Line 11: private static VmHelper instance = new VmHelper();
+1
Line 12:
Line 13: private VmHelper() {
Line 14: }
Line 15:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
Line 617: resource.setValidatorLocator(validatorLocator);
Line 618: resource.setSessionHelper(sessionHelper);
Line 619: resource.setMessageBundle(messageBundle);
Line 620: resource.setHttpHeaders(httpHeaders);
Line 621: }
i guess you could facilitate AbstractBackendResourceTest#initResource for this,
this way you won't have to double the code.
--
To view, visit http://gerrit.ovirt.org/19154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I481025152b20579ac615d9023ed0cef9b64558e1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
