Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: editConfigContent: compare strings ......................................................................
packaging: setup: editConfigContent: compare strings Make editConfigContent compare values as strings when deciding if value was changed. Without this change, an excessive comment line will be added to /var/lib/pgsql/data/postgresql.conf after comparing int(150) and str(150). Change-Id: Ia747d05416ff0ed1fbd74f0d4cce2c9f6b621755 Signed-off-by: Yedidyah Bar David <[email protected]> --- M packaging/setup/ovirt_engine_setup/util.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/20224/1 diff --git a/packaging/setup/ovirt_engine_setup/util.py b/packaging/setup/ovirt_engine_setup/util.py index 852313c..74e7c36 100644 --- a/packaging/setup/ovirt_engine_setup/util.py +++ b/packaging/setup/ovirt_engine_setup/util.py @@ -127,7 +127,7 @@ ): if ( not f.group('comment') and - f.group('value') == params[f.group('param')] + str(f.group('value')) == str(params[f.group('param')]) ): # value is not changed, do nothing processed.add(f.group('param')) -- To view, visit http://gerrit.ovirt.org/20224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia747d05416ff0ed1fbd74f0d4cce2c9f6b621755 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
