Kanagaraj M has posted comments on this change.
Change subject: gluster: Corrected the remove bricks status at iussue
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 53: GlusterVolumeTaskStatusEntity entity =
(GlusterVolumeTaskStatusEntity) returnValue.getReturnValue();
Line 54: GlusterAsyncTask asyncTask = volume.getAsyncTask();
Line 55: if (asyncTask != null) {
Line 56: Guid taskId = asyncTask.getTaskId();
Line 57: if (taskId != null) {
it could me more readable
if (asyncTask != null && asyncTask.getTaskId() != null ) {
...
}
Line 58: List<Step> stepsList =
getStepDao().getStepsByExternalId(taskId);
Line 59: if (stepsList != null && !stepsList.isEmpty()) {
Line 60:
entity.setStartTime(stepsList.get(0).getStartTime());
Line 61: }
--
To view, visit http://gerrit.ovirt.org/20181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d6d5dacffef2306545e269c2d7df08238e4e166
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
