Maor Lipchuk has posted comments on this change.
Change subject: backend, restapi: Add read-only disk functionality
......................................................................
Patch Set 7:
(2 comments)
Regarding the updateVmDisk issue you and Liron have discussed about, my
suggestion is that it will be reflected the same as plugged/unplugged, means:
* There should be a new command for updating ReadOnly.
* GUI should be the same as plugged
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1188: 0,
Line 1189: o == null ? new HashMap<String, Object>() :
(Map<String, Object>) o,
Line 1190: false,
Line 1191: true,
Line 1192: Boolean.getBoolean((String)
device.get(VdsProperties.ReadOnly)),
Method getDiskReadOnly is now redundant. please remove it
Line 1193: alias,
Line 1194: null);
Line 1195: newVmDevices.add(newDevice);
Line 1196: log.debugFormat("New device was marked for adding to VM
{0} Devices : {1}", vmId, newDevice);
Line 1198:
Line 1199: return newDeviceId;
Line 1200: }
Line 1201:
Line 1202: private boolean getDiskReadOnly(Map device) {
The method is redundant. please remove it
Line 1203: return Boolean.getBoolean((String)
device.get(VdsProperties.ReadOnly));
Line 1204: }
Line 1205:
Line 1206: /**
--
To view, visit http://gerrit.ovirt.org/15409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
