Einav Cohen has posted comments on this change. Change subject: webadmin: remove quota comsumer is broken ......................................................................
Patch Set 1: Code-Review+2 just found out that if a 'remove' confirmation dialog has its hashName set to something that begins with 'remove_', the message within the dialog cannot be overridden, which is wrong IMO, and I would like to change that behavior [1], but it should be done in a separate patch. giving "+2" for now, as I don't want to block this patch, that fixes a broken dialog behavior. [1] http://lists.ovirt.org/pipermail/engine-devel/2013-October/005732.html -- To view, visit http://gerrit.ovirt.org/19959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
