Yedidyah Bar David has posted comments on this change. Change subject: packaging: Allow restore to different db location ......................................................................
Patch Set 5: (1 comment) > either we preserve database configuration, then we do not touch it, or we get > it from user *IGNORING* whatever was there. Any hybrid solution is unexpected. Again we discuss behavior in a medium that's designed to discuss implementation. I do not think we should ignore whatever was there. I do not see why changing only some of the params is unexpected. .................................................... File packaging/bin/engine-backup.sh Line 77: SCOPE=all Line 78: START_SERVICES=0 Line 79: CHANGE_DB_CREDENTIALS=0 Line 80: MY_ENGINE_DB_HOST= Line 81: MY_ENGINE_DB_PORT= Why? Suppose the original database was remote, and now the user wants to restore to the same database, but since backup just one parameter changed - e.g., he changed the password. Why force passing all the others? Line 82: MY_ENGINE_DB_USER= Line 83: MY_ENGINE_DB_PASSWORD= Line 84: MY_ENGINE_DB_DATABASE= Line 85: MY_ENGINE_DB_SECURED= -- To view, visit http://gerrit.ovirt.org/20258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2c84111808c638a1c589cf3c14c271184a0a7c2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
