Alex Lourie has posted comments on this change. Change subject: packaging: Fixed directories and links creation ......................................................................
Patch Set 3: No score; No score (2 inline comments) .................................................... File Makefile Line 198: ln -s /usr/share/java/postgresql-jdbc.jar $(PREFIX)/usr/share/ovirt-engine/resources/jboss/modules/org/postgresql/main/ No, it adds the correct link. .................................................... File packaging/fedora/setup/engine-setup.py Line 2068: xmlObj.close() Seems so. This configures jboss configuration to include "dependencies" (which are listed above as paths). OTOH, there's a bug here, as this code will add the deps to the file regardless whether they are already there or not. -- To view, visit http://gerrit.ovirt.org/3710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f84b6060b993529819953b22ec275ac4ce30a90 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
