Doron Fediuck has posted comments on this change.
Change subject: core: Log filtering progress in scheduling
......................................................................
Patch Set 9:
(7 comments)
See inline comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 663: getRunVdssList(),
Line 664: getVdsWhiteList(),
Line 665: destinationVds == null ? null :
destinationVds.getId(),
Line 666: new ArrayList<String>(),
Line 667: new VdsFreeMemoryChecker(this),
getCorrelationId());
Please break the line between args.
Line 668: Guid vdsToRunOn = schedulingResult.getVdsSelected();
Line 669: setVdsId(vdsToRunOn);
Line 670: if (vdsToRunOn != null && !Guid.Empty.equals(vdsToRunOn)) {
Line 671: getRunVdssList().add(vdsToRunOn);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 241: parameters,
Line 242: policy.getFilterPositionMap(),
Line 243: messages,
Line 244: memoryChecker,
Line 245: correlationId, result);
please break the line between args.
Line 246:
Line 247: if (vdsList == null || vdsList.size() == 0) {
Line 248: return result;
Line 249: }
Line 341: List<VDS> hostList,
Line 342: VM vm,
Line 343: Map<String, String> parameters,
Line 344: Map<Guid, Integer> filterPositionMap,
Line 345: List<String> messages,
VdsFreeMemoryChecker memoryChecker,
Looks like wrong indention.
Line 346: String correlationId,
SchedulingResult result) {
Line 347: ArrayList<PolicyUnitImpl> internalFilters = new
ArrayList<PolicyUnitImpl>();
Line 348: ArrayList<PolicyUnitImpl> externalFilters = new
ArrayList<PolicyUnitImpl>();
Line 349: sortFilters(filters, filterPositionMap);
Line 383: reason.append(host.getId().toString());
Line 384: reason.append(") was filtered out by ");
Line 385: reason.append(actionName.name());
Line 386: reason.append(" filter ");
Line 387: reason.append(filterName);
Is it possible to use translatable strings here?
If not, you'll need to add here //$NON-NLS... to avoid breaking the tests
Line 388:
Line 389: log.info(reason);
Line 390: result.addReason(host.getId(), host.getName(),
actionName, filterName);
Line 391: }
Line 392: }
Line 393: }
Line 394:
Line 395: private List<VDS> runInternalFilters(ArrayList<PolicyUnitImpl>
filters,
Line 396: List<VDS> hostList,
Indentation?
Line 397: VM vm,
Line 398: Map<String, String>
parameters,
Line 399: Map<Guid, Integer>
filterPositionMap,
Line 400: List<String> messages,
VdsFreeMemoryChecker memoryChecker,
Line 426: reason.append(host.getId().toString());
Line 427: reason.append(") was filtered out by ");
Line 428: reason.append(actionName.name());
Line 429: reason.append(" filter ");
Line 430: reason.append(filterName);
See above comments on strings.
Line 431:
Line 432: log.info(reason.toString());
Line 433: result.addReason(host.getId(), host.getName(),
actionName, filterName);
Line 434: }
Line 435: }
Line 436: }
Line 437:
Line 438: private List<VDS> runExternalFilters(ArrayList<PolicyUnitImpl>
filters,
Line 439: List<VDS> hostList,
indentation?
Line 440: VM vm,
Line 441: Map<String, String>
parameters,
Line 442: List<String> messages,
Line 443: String correlationId,
SchedulingResult result) {
--
To view, visit http://gerrit.ovirt.org/19213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
