Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: refactoring
......................................................................
Patch Set 1:
(1 comment)
....................................................
File ovirt-engine.spec.in
Line 492: %endif
Line 493:
Line 494: %package setup-plugin-websocket-proxy
Line 495: Summary: Setup and upgrade specific plugins for websocket-proxy
Line 496: Requires: %{name}-setup-plugin-ovirt-engine-common
I admit I do not understand everything in this change, but how do you want it
to be setup by a user on such a host? Manually? The commit message says that
engine-common itself will not do anything. I thought that the intention is that
merely adding this package will make engine-setup just install webproxy.
Line 497:
Line 498: %description setup-plugin-websocket-proxy
Line 499: Setup and upgrade specific plugins for websocket-proxy
Line 500:
--
To view, visit http://gerrit.ovirt.org/20293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I572da9cd7b4a2b9e1fdfee4c05e83a0ca31b99bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
