Daniel Erez has posted comments on this change.
Change subject: webadmin: Expose read-only disk functionality in UI.
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
Line 354: DiskModel diskModel = (DiskModel) target;
Line 355: ArrayList<StorageDomain> storageDomains =
(ArrayList<StorageDomain>) returnValue;
Line 356:
Line 357: ArrayList<StorageDomain> filteredStorageDomains = new
ArrayList<StorageDomain>();
Line 358: for (StorageDomain a : storageDomains) {
for easier review, try formatting only edited lines (i.e. unrelated formatting
issues should be included in a in a separate patch).
Line 359: if (a.getStorageDomainType() !=
StorageDomainType.ISO
Line 360: && a.getStorageDomainType() !=
StorageDomainType.ImportExport
Line 361: && a.getStatus() ==
StorageDomainStatus.Active) {
Line 362: filteredStorageDomains.add(a);
Line 357: ArrayList<StorageDomain> filteredStorageDomains = new
ArrayList<StorageDomain>();
Line 358: for (StorageDomain a : storageDomains) {
Line 359: if (a.getStorageDomainType() !=
StorageDomainType.ISO
Line 360: && a.getStorageDomainType() !=
StorageDomainType.ImportExport
Line 361: && a.getStatus() ==
StorageDomainStatus.Active) {
same
Line 362: filteredStorageDomains.add(a);
Line 363: }
Line 364: }
Line 365:
Line 789: getDisk().setShareable((Boolean)
getIsShareable().getEntity());
Line 790: getDisk().setPlugged((Boolean) getIsPlugged().getEntity());
Line 791: getDisk().setPropagateErrors(PropagateErrors.Off);
Line 792:
Line 793: if (getIsReadOnly().getIsAvailable()) {
just a matter of taste - I prefer ternary if in these cases
Line 794: getDisk().setReadOnly((Boolean)
getIsReadOnly().getEntity());
Line 795: } else {
Line 796: getDisk().setReadOnly(false);
Line 797: }
Line 792:
Line 793: if (getIsReadOnly().getIsAvailable()) {
Line 794: getDisk().setReadOnly((Boolean)
getIsReadOnly().getEntity());
Line 795: } else {
Line 796: getDisk().setReadOnly(false);
shouldn't it be null?
Line 797: }
Line 798: }
Line 799:
Line 800: @Override
--
To view, visit http://gerrit.ovirt.org/20185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8d98df5e9b7aa8130b45b1ca036219175b70bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
