Yedidyah Bar David has posted comments on this change.

Change subject: packaging: engine-backup.sh fix info on failed restore
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/bin/engine-backup.sh
Line 76: 
Line 77:  Open access in the firewall/iptables/etc. to the postgresql port,
Line 78:  5432 by default.
Line 79: 
Line 80:  Open access in postgresql by adding to pg_hba.conf (which is
> well, you cannot create the database if you do not have valid hba settings... 
> so the actual order is reverse..

These are two different issues - one is be able to create the database (what we 
use 'local...peer' for), which can be done on the postgres server locally 
without network access, and the other is access by backup/engine/etc (the text 
in the change). If you want we can add also text for the first issue. In Debian 
it's configured by default - 'su - postgres -c psql' works out of the box. I 
thought it's the same in fedora, no?

> state where pg_hba is can have multiple options like in README.developer.
> Locate pg_hba.conf within your distribution,
> common locations are:
>  - /var/lib/pgsql/data/pg_hba.conf
>  - /etc/postgresql-*/pg_hba.conf
>  - /etc/postgresql/*/main/pg_hba.conf

It's already longer than I hoped. Changed anyway. Perhaps we should just put 
here a link to some wiki page.

> Storing it at /etc is much more sensible...

Of course.
Line 81:  by default in /var/lib/pgsql/data) lines like these:
Line 82: 
Line 83:  host    <database>      <user>          0.0.0.0/0               md5
Line 84:  host    <database>      <user>          ::0/0                   md5


-- 
To view, visit http://gerrit.ovirt.org/20374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I212bfdd3b362880faa7aee159866d928de83d6f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to