Gustavo Frederico Temple Pedrosa has uploaded a new change for review. Change subject: core: Fix the trimElements method of the OsRepo ......................................................................
core: Fix the trimElements method of the OsRepo Modifies the trimElements method of the OsRepositoryImpl class to filter out empty elements and correctly handle properties with empty lists as values. Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Signed-off-by: Gustavo Pedrosa <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/20453/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java index 36de148..3d5e5d1 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java @@ -349,13 +349,17 @@ * * @param elements * vararg of string elements. - * @return new list where each value its whitespaces trimmed. + * @return new list where each value its whitespaces trimmed, and + * is not added empty values. */ private ArrayList<String> trimElements(String... elements) { ArrayList<String> list = new ArrayList<String>(elements.length); for (String e : elements) { - list.add(e.trim()); + e = e.trim(); + if (e.length() > 0) { + list.add(e); + } } return list; } -- To view, visit http://gerrit.ovirt.org/20453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
