Hello James W. Mills,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/20456
to review the following change.
Change subject: Add a controlling TTY for ausearch
......................................................................
Add a controlling TTY for ausearch
The ausearch command required a controlling TTY in order to finish
execution propely. This fix adds the '-t' flag to the ssh command
used in the log-collector
Signed-off-by: James W. Mills <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1022505
Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf
---
M src/__main__.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector
refs/changes/56/20456/1
diff --git a/src/__main__.py b/src/__main__.py
index 3b48561..56d54d2 100755
--- a/src/__main__.py
+++ b/src/__main__.py
@@ -503,6 +503,10 @@
def format_ssh_command(self, cmd="ssh"):
cmd = "/usr/bin/%s " % cmd
+ # add a controlling tty
+ if cmd.startswith("/usr/bin/ssh"):
+ cmd += "-t "
+
if "ssh_port" in self.configuration:
port_flag = "-p" if cmd.startswith("/usr/bin/ssh") else "-P"
cmd += port_flag + " %(ssh_port)s " % self.configuration
--
To view, visit http://gerrit.ovirt.org/20456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: James W. Mills <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
