Yedidyah Bar David has posted comments on this change. Change subject: packaging: engine-backup: Refuse restoring to non-empty db ......................................................................
Patch Set 1: Verified+1 Note that engine-cleanup is not enough anymore, because it does not delete everything: # pg_dump -h didi-lap -U engine engine | grep -vi '^create extension' | grep -i ^create CREATE TYPE all_storage_usage_rs AS ( CREATE TYPE all_vds_group_usage_rs AS ( CREATE TYPE async_tasks_info_rs AS ( CREATE TYPE booleanresulttype AS ( CREATE TYPE disks_basic_rs AS ( CREATE TYPE get_all_commands_rs AS ( CREATE TYPE getallfromsnapshotsbyvmid_rs AS ( CREATE TYPE getallfromvm_pools_rs AS ( CREATE TYPE getnamesofvmstaticdedicatedtovds_rs AS ( CREATE TYPE getorderedvmguidsforrunmultipleactions_rs AS ( CREATE TYPE getrepo_files_in_all_storage_pools_rs AS ( CREATE TYPE getstoragedomainidsbystoragepoolidandstatus_rs AS ( CREATE TYPE getsystem_statistics_rs AS ( CREATE TYPE idtexttype AS ( CREATE TYPE iduuidtype AS ( CREATE TYPE networkviewclustertype AS ( CREATE TYPE user_permissions AS ( CREATE TYPE vds_group_usage_rs AS ( CREATE FUNCTION uuid_generate_v1() RETURNS uuid Not sure that's intended or how to cleanly solve if not. -- To view, visit http://gerrit.ovirt.org/20455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83d500e2a59e30d40c15cbde82b84d12206028dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
