Alon Bar-Lev has posted comments on this change.
Change subject: packaging: service: define ovirt-engine-notifier.conf to be
config
......................................................................
Patch Set 1:
(3 comments)
....................................................
File ovirt-engine.spec.in
Line 911: %{_bindir}/engine-config
Line 912: %{_bindir}/engine-manage-domains
Line 913: %{_mandir}/man8/engine-config.*
Line 914: %{_mandir}/man8/engine-manage-domains.*
Line 915: %{engine_data}/services/ovirt-engine-notifier
why has this moved?
Line 916: %config(noreplace)
%{engine_data}/services/ovirt-engine-notifier/ovirt-engine-notifier.conf
Line 917: %{engine_data}/bin/engine-config.sh
Line 918: %{engine_data}/bin/engine-manage-domains.sh
Line 919: %{engine_data}/bin/engine-prolog.sh
Line 912: %{_bindir}/engine-manage-domains
Line 913: %{_mandir}/man8/engine-config.*
Line 914: %{_mandir}/man8/engine-manage-domains.*
Line 915: %{engine_data}/services/ovirt-engine-notifier
Line 916: %config(noreplace)
%{engine_data}/services/ovirt-engine-notifier/ovirt-engine-notifier.conf
this is not config
Line 917: %{engine_data}/bin/engine-config.sh
Line 918: %{engine_data}/bin/engine-manage-domains.sh
Line 919: %{engine_data}/bin/engine-prolog.sh
Line 920: %{engine_data}/conf/jaas.conf
....................................................
File packaging/setup/plugins/ovirt-engine-common/system/hostile_services.py
Line 86: self._enabled and
Line 87: self.environment.get(
Line 88: osetupcons.CoreEnv.REMOVE,
Line 89: False
Line 90: ) is not True
just add not above, this is separate patch
Line 91: ),
Line 92: )
Line 93: def _closeup(self):
Line 94: for service in self._toStart:
--
To view, visit http://gerrit.ovirt.org/20461
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I597fefdd4fed70c059dbc309df7f38765336a123
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
